search

cms-PdmV / cmsPdmV

CERN CMS McM repository
4 stars 10 forks source link

Remove `cross` option for generator parameters #1131

Closed ggonzr closed 8 months ago

ggonzr commented 8 months ago

Related topic: https://cms-talk.web.cern.ch/t/problem-with-adding-cross-section-to-mcm-requests/36272/3

ggonzr commented 8 months ago

Hi @lmoureaux, this is deployed in the development instance as requested. Please check it and let me know if this solves the issue. Thanks

lmoureaux commented 8 months ago

Seems to be working in -dev (but I don't have a broken setup to compare to)

ggonzr commented 8 months ago

I suggest asking the colleague who reported this for the details of the request tried to create so that we can replicate it first in dev before merging this. Please could you ask for the details and replicate this in dev first? Thanks

lmoureaux commented 8 months ago

I reproduced in production McM with HIG-RunIISummer20UL18wmLHEGEN-13372. This request isn't in the dev database but I couldn't reproduce the same message when validating similar requests.

ggonzr commented 8 months ago

I synced the data for both environments and now the request is available in dev HIG-RunIISummer20UL18wmLHEGEN-13372. Please can you reproduce the issue and check if it is solved.

lmoureaux commented 8 months ago

I can confirm that the issue doesn't appear in dev

ggonzr commented 8 months ago

Checking again the request, I don't the issue is on our side. The last update related to the cross-section (#1126) doesn't affect any validation performed by the web server (in the backend). I am going to ask the colleague about how the generator_parameters attribute was set for its request. This seems more like an input data issue.

lmoureaux commented 8 months ago

Hi Geovanny, I confirmed that the API was used to change the cross_section in the generator parameters so it passed the check. I still think this fix is needed