Fixes for new deployment

cms-PdmV / mcm_scripts

Repository holding examples of McM scripts

5 stars 17 forks source link

Fixes for new deployment #7

Closed lmoureaux closed 1 year ago

lmoureaux commented 1 year ago

Switch to auth-get-sso-cookie
Update host names to avoid 30X responses for POST and PUT - see this answer and RFC 2616.

This also drops support for the long discontinued "integration" setup and commits the option_reset found on AFS but not on git.

ggonzr commented 1 year ago

Hi @lmoureaux, thanks for the contribution. Please can you append unit tests for the code, docs for each method available into the scripts, and typing for the variables? Thanks

lmoureaux commented 1 year ago

Please can you append unit tests for the code, docs for each method available into the scripts, and typing for the variables?

No. This is out of the scope of this PR (which is to make things run...). There are other infrastructure steps to do before we event start adding tests, the first of which is having some packaging infrastructure that documents dependencies (so that we can run tests in a CI...). Doing all of this in a single PR would make it unreviewable.

ggonzr commented 1 year ago

Hi Louis (@lmoureaux), I am going to merge this version and then we can continue working on the other points remaining. Best Geovanny