cms-analysis / CombineHarvester

CMSSW package for the creation, editing and analysis of combine datacards and workspaces
cms-analysis.github.io/CombineHarvester/
15 stars 182 forks source link

Add option in impacts plot for pulls def #136

Closed nucleosynthesis closed 6 years ago

nucleosynthesis commented 6 years ago

Uses https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/pull/431 to choose from various definitions of the "pull" to plot

nucleosynthesis commented 6 years ago

can we try to merge this? It's only related to plotting the impacts plots with alternative definitions of the pulls (as is now available with diffNuisances)

ajgilbert commented 6 years ago

Done, since unfortunately quite a few people are still using this with old versions of combine, I changed it slightly so that the external pulls module is only imported if the user explicitly sets it.

nucleosynthesis commented 6 years ago

Ok, that makes sense. Thanks!

On Thu, Jun 7, 2018 at 9:56 AM, Andrew Gilbert notifications@github.com wrote:

Done, since unfortunately quite a few people are still using this with old versions of combine, I changed it slightly so that the external pulls module is only imported if the user explicitly sets it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cms-analysis/CombineHarvester/pull/136#issuecomment-395345746, or mute the thread https://github.com/notifications/unsubscribe-auth/ABhK2zcp_MdwIpRJ0CEVpM0WKe_0u-q0ks5t6Oq7gaJpZM4Q2VNG .