search

cms-analysis / CombineHarvester

CMSSW package for the creation, editing and analysis of combine datacards and workspaces
cms-analysis.github.io/CombineHarvester/
15 stars 180 forks source link

Adds 2D plotting script PostFit2DShapesFromWorkspace.cpp #223

Closed lcorcodilos closed 1 year ago

lcorcodilos commented 5 years ago

Adds 2D plotting script PostFit2DShapesFromWorkspace.cpp and supporting infrastructure to go with the addition of a RooParametricHist2D class which has a PR here [1] with a full description.

[1] - https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/pull/545

ajgilbert commented 5 years ago

Hi Lucas, thanks for the PR. It's useful to know that there's demand for 2D shape evaluation in CH. I'm a little hesitant to merge this straightaway since it duplicates a lot of existing code, which makes things harder to maintain in the future. We've been planning to significantly rework CH under the hood this year anyway, so it might be better if we take this into account while we're doing that. Is that ok for you?

lcorcodilos commented 5 years ago

Hi Andrew, I certainly agree about the duplication of existing code. I mainly wanted to bring this forward since I'm the only one who's looked at it but I think having 2D shapes in one form or another would be beneficial to others as well. I'm happy to wait for the rework. Thanks for looking at it!