make impacts work on workspaces with > 100 processes per channel

cms-analysis / CombineHarvester

CMSSW package for the creation, editing and analysis of combine datacards and workspaces

cms-analysis.github.io/CombineHarvester/

15 stars 180 forks source link

make impacts work on workspaces with > 100 processes per channel #229

Closed hroskes closed 4 years ago

hroskes commented 4 years ago

This fixes the same segmentation fault as cms-analysis/HiggsAnalysis-CombinedLimit#559. That fix only applied when you open the workspace in the combine C++ code. When running impacts we open the workspace independently of that, so the fix doesn't get applied.

I may have missed some other places in CombineHarvester where this needs to happen as well... this is just in the impacts step.

This needs cms-analysis/HiggsAnalysis-CombinedLimit#562 to be merged first

ajgilbert commented 4 years ago

Sorry for being extremely slow on approving this - it just occurred to me that this might be a problem for people using an older release tag of combine that doesn't contain the PR mentioned above. Is it possible to modify this PR to check first if the HiggsAnalysis.CombinedLimit.RooAddPdfFixer module exists, and only import & run the fix if it does?