cms-analysis / CombineHarvester

CMSSW package for the creation, editing and analysis of combine datacards and workspaces
cms-analysis.github.io/CombineHarvester/
15 stars 180 forks source link

Check for parameters which are not "attached" #244

Open nucleosynthesis opened 4 years ago

nucleosynthesis commented 4 years ago

One rather easy bug to encounter is mis-naming of parameters in the datacard for param style nuisances. It would be good if the validation could spot this happening and warn the user. The simplest way would be to scan over parameters (maybe just nuisance parameters) and check if they have more than just the Gaussian constraint in their Client list.

Note that its not enough to check if there's a param which isn't encountered in the incoming workspaces since its feasible someone would create a param which say gets fed into a rateParam afterwards.