search

cms-analysis / CombineHarvester

CMSSW package for the creation, editing and analysis of combine datacards and workspaces
cms-analysis.github.io/CombineHarvester/
15 stars 180 forks source link

shapeN not supported #282

Open wadud001 opened 1 year ago

wadud001 commented 1 year ago

ValidateDatacards.py reports that shapeN is not supported:

https://github.com/cms-analysis/CombineHarvester/blob/112x/CombineTools/src/CombineHarvester_Datacards.cc#L453

Not sure if this is a real Harvester issue or just a lack of updating L453.

adewit commented 1 year ago

Hi, it's not simply a matter of updating L453 as the remainder of that code does things depending on the type of systematic, and shapeN also doesn't appear in the rest of the file (which is indeed probably an omission).

If you want to run ValidateDatacards in the meantime you could make another version of the card with shapeN replaced by shape, since these checks don't invoke any morphing, so the results should be equivalent.