search

cms-analysis / CombineHarvester

CMSSW package for the creation, editing and analysis of combine datacards and workspaces
cms-analysis.github.io/CombineHarvester/
15 stars 180 forks source link

`RestoreBinning` does not properly work for some binnings, e.g. DNN scores? #296

Closed pfackeldey closed 1 year ago

pfackeldey commented 1 year ago

Dear CombineHarvester experts,

we noticed an unexpected behaviour of the PostFitShapesFromWorkspace tool, when adding the datacard of a DNN score (0..1) for rebinning purposes:

The rebinned histogram had only as bin content the content of the first bin of the e.g. prefit_shapes.

Is this behaviour known?

(omitting the rebinning option via -d works fine and yields the expected output)

Best, Peter

ajgilbert commented 1 year ago

Hi Peter,

Can you tell us which branch/tag you are using? And if you can prepare a minimal example for us to reproduce that would be helpful. The bug may be something to do with matching up the categories between the workspace and the datacard, or it may be to do with the format of the datacard inputs (do you use TH1s for the DNN score distribution?)