cms-analysis / HiggsAnalysis-CombinedLimit

CMS Higgs Combination toolkit.

https://cms-analysis.github.io/HiggsAnalysis-CombinedLimit/latest

Apache License 2.0

75 stars 384 forks source link

112x: fix rateParameters ranges #777

Closed amarini closed 2 years ago

amarini commented 2 years ago

This is a bug appearing from the 112x series. Likely something has been enforced in the roofit factory expression creation.

factory expressions now needs to be in range to be created correctly. I assign as default +/- twice the value for such parameters. this should fix it for both rateParams and extArgs. Notice that this range is going to be removed after.

For the rateParameters, I put an additional check for those ranges that are input in the datacard, raising eventually an exception.

This has been tested on comb_2021_tth_multilepton.root

It should affect all the 112x series; namely 112x, 112x-comb2021, 112x-comb2022, and root626

hcombbot commented 2 years ago

Pull Request Test. Summary

Running options:

MODE : cmssw
COMBINE_TAG : 112x
COMBINE_REPO : cms-analysis
COMBINE_MERGE : amarini/112x-fix-rateparams

GITHUB_PR : 777 Ratio to reference values:

comb_2019_hbb_boosted_standalone	comb_2019_hgg	comb_2019_hmm	comb_2019_htt	comb_2019_hww	comb_2019_tth_hbb	comb_2019_tth_hgg	comb_2019_tth_multilepton	comb_2019_vh_htt	comb_2019_vhbb	comb_2019_vhbb2017
1.00	0.96	0.99	1.30	1.00	1.00	0.67	1.00	1.01	1.00	1.00

You can find more detail at https://gitlab.cern.ch/cms-hcg/performances/ci/-/pipelines/4308098

amarini commented 2 years ago

this seems good: https://gitlab.cern.ch/cms-hcg/performances/ci/-/pipelines/4308317

hcombbot commented 2 years ago

Pull Request Test. Summary

Running options:

MODE : cmssw
COMBINE_TAG : 112x
COMBINE_REPO : cms-analysis
COMBINE_MERGE : amarini/112x-fix-rateparams

GITHUB_PR : 777 Ratio to reference values:

comb_2019_hbb_boosted_standalone	comb_2019_hgg	comb_2019_hmm	comb_2019_htt	comb_2019_hww	comb_2019_tth_hbb	comb_2019_tth_hgg	comb_2019_tth_multilepton	comb_2019_vh_htt	comb_2019_vhbb	comb_2019_vhbb2017
1.00	1.00	1.00	1.00	1.00	1.00	1.00	1.00	1.00	1.00	1.00

You can find more detail at https://gitlab.cern.ch/cms-hcg/performances/ci/-/pipelines/4308750

amarini commented 2 years ago

In the last run, I change the minimizer to run w/ as many calls as it needs and everything is aligned.

nsmith- commented 2 years ago

So previously some const rateParams were being clamped to [0, 1] interval and hence the fit results disagreed?

amarini commented 2 years ago

Yes, parameters were cropped in the [0,1] interval. In previous versions of ROOT, the factory seemed to have a different behavior. Although, I remember that in doing setParameters the range was already an issue in the 102x root version.