search

cms-analysis / HiggsAnalysis-CombinedLimit

CMS Higgs Combination toolkit.
https://cms-analysis.github.io/HiggsAnalysis-CombinedLimit/latest
Apache License 2.0
75 stars 384 forks source link

Allow ChannelCompatibilityCheck to skip channels with no signal templates #805

Closed Dominic-Stafford closed 1 year ago

Dominic-Stafford commented 1 year ago

Fixes #801 by skipping channels where the POI was not fitted due to missing signal templates in CRs. Also added a continue statement in FitterAlgoBase.cc to skip parameters which are not present also if the analytic minimiser is not used, to avoid a seg fault at RooRealVar &rf = dynamic_cast<RooRealVar &>(*rfloat); (I only encountered this issue with the latest versions of combine due to the switch of the default Minimizer from non-analytic to analytic). I haven't checked if this latter change affects other scripts, as I wasn't sure which tests to do, but can do some if requested.

ajgilbert commented 1 year ago

Thanks for this. We'll merge this shortly, but note that we don't anticipate a new combine release based on the 102x branch, instead developments are taking place on the 112x branch, where we've also ported this PR.