search

cms-analysis / HiggsAnalysis-CombinedLimit

CMS Higgs Combination toolkit.
https://cms-analysis.github.io/HiggsAnalysis-CombinedLimit/latest
Apache License 2.0
75 stars 381 forks source link

Nckw new logger #868

Closed nucleosynthesis closed 9 months ago

nucleosynthesis commented 10 months ago

Minimial version of CombineLogger written. Replaces Logger with stripped down version (CombineLogger)

nucleosynthesis commented 10 months ago

Currently, the log file name defaults to the previous combine_logger.out but functionality is there to specify a name. This needs to be done here : https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/nckw_new_Logger/bin/combine.cpp#L55 , however the code is structured so that string components that make up the ROOT file name are created much later so formatting the same as the file name would require some restructuring.

nucleosynthesis commented 9 months ago

I think there's a lot of good progress here so I'd be in favour of merging and then we can make more improvements down the road @giacomoortona ?

giacomoortona commented 9 months ago

Agree