search

cms-analysis / HiggsAnalysis-CombinedLimit

CMS Higgs Combination toolkit.
https://cms-analysis.github.io/HiggsAnalysis-CombinedLimit/latest
Apache License 2.0
75 stars 381 forks source link

Support ROOT 6.30 and C++20 #873

Closed guitargeek closed 9 months ago

guitargeek commented 9 months ago

The necessary changes to make combine compatible with ROOT 6.30 (and even master) compiled with the C++20 standard.

More detail in the commit descriptions.

guitargeek commented 9 months ago

Hi @anigamova and @kcormi, would it be fine to merge this? It's a purely technical change that enables us to try out new ROOT versions in order to see how combine can benefit from the newest RooFit features

kcormi commented 9 months ago

Hi @guitargeek, thanks for these updates. Unfortunately with the relative paths, we had some issues previously as this was breaking the build in CMSSW, this popped up when we merged #809 and then was reverted to fix the compilation in #846. I think @nsmith- was planning to look into this, I wouldnt think it should be so difficult to fix, but I haven't done so since an original check when the build was breaking.

guitargeek commented 9 months ago

Ah ok, no problem! I have dropped the commit with the relative paths from this PR. After all, this was not relevant to support ROOT 6.30 with C++20, but only for my local build with CMake.

kcormi commented 9 months ago

Okay, great, thanks! I think its fine then, and builds fine in CMSSW as well.