cms-analysis / HiggsAnalysis-CombinedLimit

CMS Higgs Combination toolkit.
https://cms-analysis.github.io/HiggsAnalysis-CombinedLimit/latest
Apache License 2.0
75 stars 380 forks source link

Override getParameters for main #905

Closed anigamova closed 6 months ago

anigamova commented 6 months ago

Same as #903, provide a fix for discrete profiling in root v6.26

guitargeek commented 4 months ago

Thanks for this! There are some issues with it still:

All this this is not your fault: I should have been more careful when changing interfaces, and combine should have used the override keyword like the rest of CMSSW to catch this early.

Sustainable fix proposed in: https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/pull/948

anigamova commented 4 months ago

Thanks @guitargeek for looking into this and providing a better fix for this issue. We'll test the changes from #948 and hopefully merge it soon