Fix RooStats::ToyMCSampler pointer issue for ROOT v6.22/09

cms-analysis / HiggsAnalysis-CombinedLimit

CMS Higgs Combination toolkit.

https://cms-analysis.github.io/HiggsAnalysis-CombinedLimit/latest

Apache License 2.0

75 stars 380 forks source link

Fix RooStats::ToyMCSampler pointer issue for ROOT v6.22/09 #938

Closed clelange closed 4 months ago

clelange commented 4 months ago

ROOT v6.22/09 is actually not an official release but is in the v6-22-00-patches branch, which got this change: https://github.com/root-project/root/commit/e24f87734ca447e0e9c3e26d47496c02d2a2f4f9 that also went into all later releases (6.24 onwards).

nucleosynthesis commented 4 months ago

Can this one safely be merged for use with the current recommended CMSSW release?

clelange commented 4 months ago

I would think so but it's better to check. I was planning on adding some more serious CI that also uses CMSSW. Let's maybe wait for this before merging.

nucleosynthesis commented 4 months ago

Ok, in general we should probably extend our CI tests since they are mostly based on fits and not so much on Toy-based calculations (iirc), so that all sounds reasonable