search

cms-analysis / HiggsAnalysis-CombinedLimit

CMS Higgs Combination toolkit.
https://cms-analysis.github.io/HiggsAnalysis-CombinedLimit/latest
Apache License 2.0
75 stars 378 forks source link

Use `override` keyword were necessary #948

Closed guitargeek closed 1 month ago

guitargeek commented 3 months ago

To avoid future mistakes when overriding functions, this commit suggests to use the override keyword as suggested by clang-tidy.

How this commit was produced:

  1. Compile with CMake, exporting the compile commands as described here: https://stackoverflow.com/questions/20059670/how-to-use-cmake-export-compile-commands

  2. Build

  3. Run this in the build directory: run-clang-tidy -header-filter="interface/.*" -config-file=../.clang-tidy -export-fixes fixes.yaml . -j20

  4. Copy the fixes.yaml back to the main repo and apply fixes with: clang-apply-replacements .

anigamova commented 3 months ago

@guitargeek could you please update this PR with the latest main to include the new workflow added with this https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/pull/946 ?

guitargeek commented 3 months ago

Sure! I updated the PR. Thanks so much for taking care of it, @anigamova!

guitargeek commented 3 months ago

I have updated all my other PRs as well: https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/pulls/guitargeek

All these PRs are only technical but necessary for ROOT compatibility, so it would be nice if you can have a look at the others too :+1: