cms-analysis / HiggsAnalysis-CombinedLimit

CMS Higgs Combination toolkit.
https://cms-analysis.github.io/HiggsAnalysis-CombinedLimit/latest
Apache License 2.0
75 stars 383 forks source link

Avoid problems with `FastVerticalInterpHistPdf2Base` initialization #952

Closed guitargeek closed 4 months ago

guitargeek commented 5 months ago

The _sentry is already filled when calling evaluate(), so no need to do that in the copy constructor: https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/main/src/VerticalInterpHistPdf.cc#L895

Doing so can actually leading to redundant calls to _sentry.addVars(_coefList), resulting in the problem reported here: https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/pull/940#issuecomment-2064076625

[#0] ERROR:InputArguments -- RooArgSet::checkForDup: ERROR argument with name CMS_vhbb_stats_TT_ZmmLoose7TeV is already in this set

FYI @kcormi