search

cms-analysis / HiggsAnalysis-CombinedLimit

CMS Higgs Combination toolkit.
https://cms-analysis.github.io/HiggsAnalysis-CombinedLimit/latest
Apache License 2.0
75 stars 378 forks source link

Warning about long formulas still relevant? #953

Open nsmith- opened 2 months ago

nsmith- commented 2 months ago

We still have a warning

Executing factory with a string of length  1948  > 1000, could trigger a bug: ...

in the code at https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/e7f355d2228a754c3b0a865912836e9e05f07f64/python/ModelTools.py#L95-L101 and around since 2012 https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/commit/25333c47cfef82f0e4d02b68cdd7e81d1565e0d1#diff-6aff0212eae895e959674ba1ef93b157076c49d94d89513acbb130b05f72d480R35-R36 Do we know if/when RooFit fixed this?