cms-analysis / HiggsAnalysis-CombinedLimit

CMS Higgs Combination toolkit.
https://cms-analysis.github.io/HiggsAnalysis-CombinedLimit/latest
Apache License 2.0
75 stars 383 forks source link

Add workflow description to contributing.md #954

Closed anigamova closed 5 months ago

kcormi commented 5 months ago

This is nice, thanks!

Could we perhaps switch the images to using the markdown format:

![alternative text](img path)

I think other html properties can be added with

![alternative text](img path){:property1=value1 :property2=value2}

syntax, but I haven't tried it, so we should check if it renders properly. It would just be nice if we keep things more markdown so that it is still more readable even when its not being rendered somewhere. But providing the alt-text even in the html could be fine if the markdown doesnt work well.

@nucleosynthesis are there other things/information about the Github actions we should add?

nucleosynthesis commented 5 months ago

Looks good to me content wise - we can add more once we include more datacard checks !

On Fri, 26 Apr 2024, 08:26 kcormi, @.***> wrote:

This is nice, thanks!

Could we perhaps switch the images to using the markdown format:

![alternative text](img path)

I think other html properties can be added with

![alternative text](img path){:property1=value1 :property2=value2}

syntax, but I haven't tried it, so we should check if it renders properly. It would just be nice if we keep things more markdown so that it is still more readable even when its not being rendered somewhere. But providing the alt-text even in the html could be fine if the markdown doesnt work well.

@nucleosynthesis https://github.com/nucleosynthesis are there other things/information about the Github actions we should add?

— Reply to this email directly, view it on GitHub https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/pull/954#issuecomment-2078791722, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMEVW4L25AT2FVNUSCY5K3Y7H6S7AVCNFSM6AAAAABGYXISKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZYG44TCNZSGI . You are receiving this because you were mentioned.Message ID: @.***>

anigamova commented 5 months ago

Unfortunately resizing does not work with markdown syntax, so I just removed these absolutely unnecessary images