search

cms-analysis / HiggsAnalysis-KITHiggsToTauTau

http://cms-analysis.github.io/HiggsAnalysis-KITHiggsToTauTau/
6 stars 18 forks source link

Moved Rochester Muon Corrections to Artus #39

Closed annafriedel closed 8 years ago

annafriedel commented 8 years ago

Due to the movement of the HttMuonCorrectionsProducer to Artus some changes have to be done in this Repository as well. Please check if everything works as usual with this changes and the changes made in the Artus pull request. I hope it does, but since I'm not used to the Htt analysis I can't check it myself.

anehrkor commented 8 years ago

Hi Anna,

thanks for taking care of this! However, please do not completely remove the HttMuonCorrectionsProducer since it is needed for this operation in some cases. So if you could, please only remove the stuff connected to the rochester corrections.

Best, Alex

thomas-mueller commented 8 years ago

Hi Anna,

I checked your changes and can confirm, that we get the same result as before. So I will merge both pull request after Alex's question is answered.

I have just a very small comment regarding the class structure of the muon corrections: I am not completely sure, whether deriving a new class for every correction is the best way to do. It becomes problematic in case one wants to apply more than just one correction. In case this is needed, I propose to move the code from the RochMuonCorrectionsProducer into the Produce function of the upper class MuonCorrectionsProducer and switch it on/off as you do it know and as for example different IDs are switched on/off in the ValidMuonsProducer.

Cheers, Thomas

annafriedel commented 8 years ago

Ok thank you for your suggestions and also thank you for testing, Thomas.

Cheers, Anna

annafriedel commented 8 years ago

Now I hope I did everything as suggested. Please check again if everything works as intended in Htt analysis. One more Question: Is this still needed? I do not really understand what this is for.

Cheers, Anna

anehrkor commented 8 years ago

Hi Anna,

after removing a few inclusions of header files that no longer exist, everything seems to be working. Both rochester corrections and the energy scale shift show reasonable/expected results.

So I think we can merge this PR and the one in Artus. Thanks for your help with the changes in this repository! :)

Cheers, Alex

PS: I'm also not sure what this multiplication with 1.0 is for...