Fix a bug in the computation of Up and Down MVA shift

cms-analysis / flashgg

20 stars 158 forks source link

Closed alesauva closed 4 years ago

alesauva commented 4 years ago

Found a bug that causes the up and down shift of the phoID MVA syst unc to be flipped:

The input to the shifts are graph that map the nominal_MVA to the shifted_MVA value.
The correction was computed as nominal_MVA-shifted_MVA and this value is then add back to the original_MVA (this is also unnecessary in itself, should be investigated further).
FIX: nominal-shifted replaced by shifted-nominal.

alesauva commented 4 years ago

Is it fine now ?

simonepigazzini commented 4 years ago

Yes! Thank you!