cms-analysis / flashgg

20 stars 158 forks source link

Update UL 17 ingredients #1227

Closed edjtscott closed 3 years ago

edjtscott commented 4 years ago

This PR designed to include the required updates for the UL 17 dataset. So far just updates the photon systematics file in the MetaConditions (previously not set to the legacy version) and adds the databases needed for the JEC and JER (not yet included in any global tag).

Expect additional commits from @rchatter but these two aspects should be the most important ones for anyone hoping to run ntuples asap.

rchatter commented 4 years ago

Hi, The commits that are expected but pending are the following 1) Electron ID SFs : need to create a combined JSON of ID SFs. Have located Francesco's code and instructions (https://indico.cern.ch/event/842077/contributions/3633040/attachments/1941671/3219683/egm_08Nov19.pdf and https://github.com/michelif/json_converter_egID). Trying to get it running. 2) Muon ID SFs : Missing the low pt ID SFs. Following up with Muon POG https://hypernews.cern.ch/HyperNews/CMS/get/muon/1666/1.html 3) B Tag SFs missing for UL 17 : Following up with BTV POG https://hypernews.cern.ch/HyperNews/CMS/get/btag/1809.html

Rajdeep

simonepigazzini commented 4 years ago

@edjtscott are you sure that the JEC and JER are not available through Frontier and only through the sqlite file?

edjtscott commented 4 years ago

In the tables here it says the GT with these corrections is tba, which is why I added them by hand

edjtscott commented 4 years ago

@simonepigazzini I now tried reverting to frontier, as we discussed. It seems that the JEC are there but not the JER; I'm currently getting an error Tag "JR_Summer19UL17_JRV2_MC_PtResolution_AK4PFchs" has not been found in the database.

So if OK with you I will leave it as-is for now?

simonepigazzini commented 4 years ago

Ok fine. I will blame JME for sinking my masterplane of reading everything from db

edjtscott commented 3 years ago

hi all (@simonepigazzini @youyingli @zhangyu0217), this PR should now be complete from our side. Could you double check it all looks sensible before merging? Thanks a lot