cms-analysis / flashgg

20 stars 158 forks source link

Fix the bug for high/low weight due to MC pileup overwritten for UL2017 #1230

Closed youyingli closed 3 years ago

youyingli commented 3 years ago

[1] https://github.com/cms-sw/cmssw/blob/CMSSW_10_6_X/SimGeneral/MixingModule/python/mix_2017_25ns_UltraLegacy_PoissonOOTPU_cfi.py#L2 https://github.com/cms-sw/cmssw/blob/CMSSW_10_6_X/SimGeneral/MixingModule/python/mix_2018_25ns_JuneProjectionFull18_PoissonOOTPU_cfi.py#L2

youyingli commented 3 years ago

Hi @edjtscott and @Joe-W-Davies, could you please check if this bug-fixing PR can solve the high/low weight problem mentioned from

https://indico.cern.ch/event/943905/contributions/4033510/attachments/2111058/3551063/UL_vs_ReReco_2017.pdf

edjtscott commented 3 years ago

hi @youyingli yes for sure, we are going to include it in our next ntuple production to check the weights are returned to normal. We will let you know as soon as it's done

edjtscott commented 3 years ago

Thanks a lot @youyingli for this PR - @Joe-W-Davies has now tested it and confirmed that the weights now behave sensibly

youyingli commented 3 years ago

Thank @edjtscott @Joe-W-Davies for confirmation. The PR is ready to merge.