Fix the muon SF for UL and tag names for Jet Resolution in 2016 UL

cms-analysis / flashgg

20 stars 158 forks source link

Fix the muon SF for UL and tag names for Jet Resolution in 2016 UL #1293

Closed emanueledimarco closed 1 year ago

emanueledimarco commented 1 year ago

muon SFs are for 2016 vs abs(eta)
fix typo in the tag names for 2016 preVFP and post VFP JR

youyingli commented 1 year ago

To remove the eta extension part should be suitable as we have taken the absolute value to muon eta.

emanueledimarco commented 1 year ago

Yes this is what I did I think in the last commit 38c7368, no?

youyingli commented 1 year ago

Sorry for the late review. Your modification could still create some useless negative-eta bins as the muon now take the absolute value. You should remove L92-L99, L123-L130, L139-L146, L156-L163, L198 and modify L101 back to pt_bins[ pt_from ] = self.binInfo.bins[-1] and L165-L166 back to pt_bins[ sorted(pt_bins.keys())[-1] ].upBounds[1] = float( 'inf' ).

JunquanTao commented 1 year ago

Hi Youying @youyingli , I have also sumitted a PR severals ago and do some changes on the file "flashggMuonSystematics_cfi.py". Please review it. Thanks, Junquan [1] https://github.com/cms-analysis/flashgg/pull/1295

emanueledimarco commented 1 year ago

@youyingli thanks, I didn't notice those pieces. Should be removed now.

youyingli commented 1 year ago

@emanueledimarco thanks. Merged!