search

cms-analysis / flashgg

20 stars 158 forks source link

Updated UL16 scales and smearings to stochastic #1294

Closed neilSchroeder closed 1 year ago

JunquanTao commented 1 year ago

Hi Neil, where we can find these scaling and smearing files EgammaAnalysis/ElectronTools/data/ScalesSmearings/Run2016_2021-07-07_postVFP_stochastic_oldFormat* ? You need to put them in https://github.com/rchatter/EgammaAnalysis-ElectronTools.git. Then people can check out these files with https://github.com/cms-analysis/flashgg/blob/dev_legacy_runII/setup_flashgg.sh#L54 . Right? Thanks, Junquan

JunquanTao commented 1 year ago

Hi all, Rajdeep just committed the UL16 ET dependent scales and smearings to his github repos. [1]. So the changes in this PR should work fine now. Thanks, Junquan [1] https://github.com/rchatter/EgammaAnalysis-ElectronTools/commit/a7ed824d4ffbd6dfc884b2a06da7ae6b1c4db889

youyingli commented 1 year ago

Hi @JunquanTao, @neilSchroeder, #1295 cover this PR which would be fine to close?

JunquanTao commented 1 year ago

Hi @youyingli, I think so. @neilSchroeder should confirm this.

neilSchroeder commented 1 year ago

Hi @JunquanTao and @youyingli, the scales and smearing listed in #1295 are an older version of the scales that are not Et dependent, so I do not think this is ready to close.

JunquanTao commented 1 year ago

Hi @neilSchroeder , the paths were updated. Can you please check https://github.com/cms-analysis/flashgg/pull/1295 again. Thanks, Junquan

neilSchroeder commented 1 year ago

Hi yes, I see now. I will close this.