avoid setting ROOT in batch mode

cms-cat / cmsstyle

Holding repo for CMS plotting style ROOT macros

https://cmsstyle.readthedocs.io/

MIT License

8 stars 10 forks source link

avoid setting ROOT in batch mode #42

Closed lenzip closed 5 months ago

lenzip commented 6 months ago

Dmytro Kovalskyi reported cmsstyle sets rt.gROOT.SetBatch(rt.kTRUE). It would be better to avoid that. Not necessarly one wants to work in batch mode with cmsstyle.

anmalara commented 6 months ago

I think I disagree on this point. There is no need to run in iterative mode when producing plots. It is actually much more slower. And in any case one can unset it manually if needed.

lenzip commented 6 months ago

Well, likewise one can set it manually if needed in the calling code, like I did in my PR. I think we should do least unexpected global changes as possible.

ttedeschi commented 5 months ago

Solved by https://github.com/cms-cat/cmsstyle/pull/43