Consistency of log severities

stefano-maggiolo commented 11 years ago

If you vote for me, I promise I'll change all logs.critical that do not terminate the program to log.error, and stuff like that. Having a log.error is bad enough, no need to use a higher priority for things that are really bad since critical has the semantic that the service is going to terminate.

Indeed, I'll also add these explanations in doc/:

The meaning of the severity of a log message is as follows:

debug: you can ignore them, also because you are encouraged to never see them;
info: they inform you on what is going on in the system and that everything is fine;
warning: something went wrong or was slightly unexpected, but CMS knew how to handle it, or someone fed inappropriate data to CMS (by error or on purpose); you may want to check these as they may evolve into errors or unexpected behaviors, or hint that someone is trying to do nasty things;
error: an unexpected condition that should not have happened; you are really encouraged to take actions to fix them, but the service will continue to work (probably ignoring the error and the data connected to it);
critical: a condition so unexpected that the service is really startled and refuses to continue working; you are forced to take action because with high probability the service will continue restarting itself.

lw commented 11 years ago

I'll vote for you only if you're gonna stop world hunger too!

(Just kidding... +1 to the proposal)

giomasce commented 11 years ago

Hi.

Il 10/12/2012 07:50, Stefano Maggiolo ha scritto:

If you vote for me, I promise I'll change all logs.critical that do not terminate the program to log.error, and stuff like that. Having a log.error is bad enough, no need to use a higher priority for things that are really bad since critical has the semantic that the service is going to terminate.

I vote for you. With a few comments on the wording of here under:

Indeed, I'll also add these explanations in doc/:

--- The meaning of the severity of a log message is as follows:

debug: you can ignore them, also because you are encouraged to never see them;.

It is not clear what "encouraged to never see them" means: as a user, I would understand that it is better if I close my eyes when a debug message is sent.

warning: something went wrong or was slightly unexpected, but CMS knew how to handle it, or someone fed inappropriate data to CMS (by error or on purpose); you may want to check these as they may evolve into errors or unexpected behaviors, or hint that someone is trying to do nasty things;

What are "nasty things"? I'd say "someone is trying to cheat", which seems to me more understandable from a user that doesn't know CMS well.

Thanks, Giovanni.

Giovanni Mascellani mascellani@poisson.phc.unipi.it Pisa, Italy

Web: http://poisson.phc.unipi.it/~mascellani Jabber: g.mascellani@jabber.org / giovanni@elabor.homelinux.org

stefano-maggiolo commented 11 years ago

Thanks Gio for the suggestions. Closing by 6268461fb0bdb8c70d41336a58b13078e3e0158d.

cms-dev / cms

Consistency of log severities #78

Thanks, Giovanni.