cms-dev / cms

Contest Management System
http://cms-dev.github.io/
GNU Affero General Public License v3.0
891 stars 361 forks source link

Update isolate to 1.6 #855

Closed gollux closed 6 years ago

gollux commented 6 years ago

I and Bernard just released isolate 1.5, could you please update the isolate submodule to point to the new tag?

We fixed some security issues (however, none can be exploited from the submitted solutions, they just allow the user running isolate to bypass directory access permissions in some cases) and some bugs.

There is one place where we break backward compatibility: previously, if --stderr was not specified, stderr was automatically redirected to stdout. This was unlike --stdin and --stdout, which default to inheriting the file descriptor from the parent. We changed the default to inherit stderr, too. Please check that it does not affect CMS. (I tried to review that, but I am not sure what is the expected behavior of the Sandbox class when stderr_file is not specified by the caller.)

gollux commented 6 years ago

Sorry, I just found a bug in enforcing time limits in the current version. I will fix it soon, progress is tracked at https://github.com/ioi/isolate/issues/52.

stefano-maggiolo commented 6 years ago

Good thing we are slow :)

gollux commented 6 years ago

Good thing we are slow :)

:) I hope the bug is fixed in isolate master, but it would be fine if it received a bit of additional testing before I release it. Could you please give it a try?

stefano-maggiolo commented 6 years ago

Hello, any news on isolate 1.6?

gollux commented 6 years ago

Hello, any news on isolate 1.6?

I hoped to hear from Bernard what he thinks about my changes :)

However, I have tested current isolate in a couple of local contests, so I think I can release it today.

stefano-maggiolo commented 6 years ago

Well, no rush on our side if you have a reason to wait! Thanks

gollux commented 6 years ago

I just released isolate 1.6.

stefano-maggiolo commented 6 years ago

Updated, thanks Martin!