search

cms-dev / isolate

Sandbox for securly executing untrusted programs - DEPRECATED, use: https://github.com/ioi/isolate
47 stars 14 forks source link

Increase default num boxes #22

Closed wil93 closed 8 years ago

wil93 commented 8 years ago

This is necessary if you use CMS and want to start more than 10 workers on the same machine (otherwise, the workers will fail often). For example, on our private server (which has 32 cores) we sometimes use up to 16 workers.

wil93 commented 8 years ago

D'oh

gollux commented 8 years ago

I plan to get rid of config.h altogether and replace it by a proper configuration file (it however needs some thought to make it secure enough). Before this happens, your patch will be a good temporary fix.

OTOH, why does CMS reserve 10 boxes per worker?

wil93 commented 8 years ago

CMS does not. We (on our private server) do, by editing the cms.conf file :smile:

EDIT: oh, I misunderstood. I think it's because some TaskType require multiple steps (but definitely not 10). Last time I spoke with him, I think @stefano-maggiolo suggested lowering that to 5.

gollux commented 8 years ago

I understood that you use more workers on your server, but I asked about the number of boxes required by a single worker :)

wil93 commented 8 years ago

Yes sorry, I edited my comment above :smile:

gollux commented 8 years ago

OK :-) I merged one of the other pull requests :)

stefano-maggiolo commented 8 years ago

To answer re CMS, we do "reserve" 10 boxes per worker - some task type might use more than one box (I think the maximum is 3 at the moment). 10 could probably be lowered, but the usual situation is that we have very few workers per machine anyway.