search

cms-externals / geant4

CMS mirror of Geant4 sources. Not endorsed by Geant4 organization itself under any circumstance.
Other
2 stars 6 forks source link

identical CMakeLists.txt files in 4.10.04.b01 #22

Closed smuzaffar closed 7 years ago

smuzaffar commented 7 years ago

@civanch , looks like we have a wrong cmake file source/CMakeLists.txt. It used to look like this https://github.com/cms-externals/geant4/blob/cms/4.10.02.p02/source/CMakeLists.txt but now we have two idential file

https://github.com/cms-externals/geant4/blob/cms/4.10.04.b01/source/CMakeLists.txt https://github.com/cms-externals/geant4/blob/cms/4.10.04.b01/CMakeLists.txt

copying https://github.com/cms-externals/geant4/blob/cms/4.10.02.p02/source/CMakeLists.txt to 4.10.04.b01/source/CMakeLists.txt let me start the build. Please check with geant4 developers why these files are identical.

cmsbuild commented 7 years ago

A new Issue was created by @smuzaffar Malik Shahzad Muzaffar.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

civanch commented 7 years ago

@smuzaffar , in geant4 these files are different, likely something happens with the patch. In the area where the patch was prepared both in ref07 and previous these files are identical, while if one clone a fresh variant geant4 from previous git branches they are different. Likely, it is my mistake but not clear how it is possible to do technically. If such happens we cannot trust to this patch/PR.

In a mean time a new reference version is available and a fresh tar is prepared: ~civanch/public/geant4.10.3ref08.tar.gz May be optimal make it as a new branch? We may skip ref07 now.

smuzaffar commented 7 years ago

thanks, I have now pushed the ref-08 change for https://github.com/cms-externals/geant4/tree/cms/4.10.04.b01