search

cms-externals / geant4

CMS mirror of Geant4 sources. Not endorsed by Geant4 organization itself under any circumstance.
Other
2 stars 6 forks source link

Fixed Physics List destruction #54

Closed civanch closed 2 years ago

civanch commented 3 years ago

Address cms-sw issue #34271

cmsbuild commented 3 years ago

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for branch cms/v10.7.2.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks. @silviodonato, @dpiparo, @qliphy you are the release manager for this. cms-bot commands are listed here

civanch commented 3 years ago

This PR needs extra commit - not yet ready for test.

cmsbuild commented 3 years ago

Pull request #54 was updated.

civanch commented 3 years ago

please test

smuzaffar commented 3 years ago

@civanch , by default bot will test it against normal 12.0.X IBs. Shouldn;t we test it against the special G4 Ibs?

smuzaffar commented 3 years ago

please test for CMSSW_12_0_G4VECGEOM_X

smuzaffar commented 3 years ago

please test for CMSSW_12_0_GEANT4_X

civanch commented 3 years ago

@smuzaffar , thanks! By the way, all 3 tests should pass (my expectation).

cmsbuild commented 3 years ago

-1

Failed Tests: Build Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4a8a/16419/summary.html COMMIT: 854b484751e498df6e22df8732af2d3707856577 CMSSW: CMSSW_12_0_X_2021-07-02-1100/slc7_amd64_gcc900 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/geant4/54/16419/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building: 

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-02-1100/src/CondFormats/SiPhase2TrackerObjects/src/SiPhase2OuterTrackerLorentzAngle.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-02-1100/src/CondFormats/SiPhase2TrackerObjects/src/T_EventSetup_SiPhase2OuterTrackerLorentzAngle.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-02-1100/src/CondFormats/SiPhase2TrackerObjects/src/T_EventSetup_TrackerDetToDTCELinkCablingMap.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-02-1100/src/CondFormats/SiPhase2TrackerObjects/src/TrackerDetToDTCELinkCablingMap.cc
>> Compiling  tmp/slc7_amd64_gcc900/src/CondFormats/SiPhase2TrackerObjects/src/CondFormatsSiPhase2TrackerObjects/a/Serialization.cc
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/SiPhase2TrackerObjects/src/CondFormatsSiPhase2TrackerObjects/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/SiPhase2TrackerObjects/src/CondFormatsSiPhase2TrackerObjects/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.
cmsbuild commented 3 years ago

-1

Failed Tests: Build Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4a8a/16420/summary.html COMMIT: 854b484751e498df6e22df8732af2d3707856577 CMSSW: CMSSW_12_0_G4VECGEOM_X_2021-07-01-2300/slc7_amd64_gcc900 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/geant4/54/16420/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building: 

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_G4VECGEOM_X_2021-07-01-2300/src/CondFormats/SiPhase2TrackerObjects/src/SiPhase2OuterTrackerLorentzAngle.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_G4VECGEOM_X_2021-07-01-2300/src/CondFormats/SiPhase2TrackerObjects/src/T_EventSetup_SiPhase2OuterTrackerLorentzAngle.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_G4VECGEOM_X_2021-07-01-2300/src/CondFormats/SiPhase2TrackerObjects/src/T_EventSetup_TrackerDetToDTCELinkCablingMap.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_G4VECGEOM_X_2021-07-01-2300/src/CondFormats/SiPhase2TrackerObjects/src/TrackerDetToDTCELinkCablingMap.cc
>> Compiling  tmp/slc7_amd64_gcc900/src/CondFormats/SiPhase2TrackerObjects/src/CondFormatsSiPhase2TrackerObjects/a/Serialization.cc
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/SiPhase2TrackerObjects/src/CondFormatsSiPhase2TrackerObjects/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/SiPhase2TrackerObjects/src/CondFormatsSiPhase2TrackerObjects/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.
cmsbuild commented 3 years ago

-1

Failed Tests: Build Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4a8a/16421/summary.html COMMIT: 854b484751e498df6e22df8732af2d3707856577 CMSSW: CMSSW_12_0_GEANT4_X_2021-06-29-2300/slc7_amd64_gcc900 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/geant4/54/16421/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building: 

ImportError: No module named clang.cindex
gmake: *** [tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc] Error 1
Entering library rule at CondFormats/GBRForest
>> Compiling LCG dictionary: tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/CondFormatsGBRForest_xr.cc
>> Compiling  tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.
civanch commented 3 years ago

@smuzaffar , I do not thing problem of the test connected with this PR, likely it is due to inconsistency of IB and this new branch.

smuzaffar commented 3 years ago

@civanch , yes we are changing a lot python packages this was due to missing llvm python2. This has been fixed now but there is no geant4 IB yet based on the latest externals. Let me build a geant4 IB so that we can test this PR

smuzaffar commented 3 years ago

please test

smuzaffar commented 3 years ago

please test for CMSSW_12_0_GEANT4_X

cmsbuild commented 3 years ago

-1

Failed Tests: UnitTests Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4a8a/16514/summary.html COMMIT: 854b484751e498df6e22df8732af2d3707856577 CMSSW: CMSSW_12_0_GEANT4_X_2021-07-06-1100/slc7_amd64_gcc900 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/geant4/54/16514/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS

Comparison Summary

Summary:

cmsbuild commented 3 years ago

-1

Failed Tests: UnitTests Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4a8a/16513/summary.html COMMIT: 854b484751e498df6e22df8732af2d3707856577 CMSSW: CMSSW_12_0_X_2021-07-06-1100/slc7_amd64_gcc900 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/geant4/54/16513/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS

Comparison Summary

Summary:

civanch commented 3 years ago

@smuzaffar , there is no regression in several WFs. It seems not to be connected with this PR.

civanch commented 2 years ago

@smuzaffar , can test be restarted ?

smuzaffar commented 2 years ago

please test

cmsbuild commented 2 years ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4a8a/16735/summary.html COMMIT: 854b484751e498df6e22df8732af2d3707856577 CMSSW: CMSSW_12_0_X_2021-07-12-2300/slc7_amd64_gcc900 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/geant4/54/16735/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

civanch commented 2 years ago

@smuzaffar , I suspect that failed tests are not related to this PR.

smuzaffar commented 2 years ago

please test

cmsbuild commented 2 years ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4a8a/16787/summary.html COMMIT: 854b484751e498df6e22df8732af2d3707856577 CMSSW: CMSSW_12_0_X_2021-07-13-1100/slc7_amd64_gcc900 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/geant4/54/16787/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

smuzaffar commented 2 years ago

@civanch , there are too many comparison failures. Do you understand those? were these expacted with this change?

civanch commented 2 years ago

@smuzaffar , this fix is only in the class destructor, so cannot affect run time. I suspect that problem is in what compared to what. This patch should be put on top of 10.7.2, if it is compared with the master, then we compare 10.7.1 and 10.7.2.

smuzaffar commented 2 years ago

yes we are currently comparing 10.7.1 with 10.7.2+patch. So how do you suggest we proceed? We get this in GEANT4 IB and then build geant4 release to validate 10.7.2?

civanch commented 2 years ago

@smuzaffar , yes, I think this PR can be merged to this 10.7.2 branch and it would be good to have a new IB 12_0_0_pre4_G410.7.2_VecGeom