Fix FTFP_BERT_EMM Physics list for Geant4 11.0

[civanch]

This is a critical fix for HCAL simulation with CMS default Physics List FTFP_BERT_EMM. The problem does not affect Physics Lists from Geant4 distribution. It exist in Geant4 11.0 and not in the master version.

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for branch cms/v11.0.1.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. @perrotta, @dpiparo, @qliphy you are the release manager for this. cms-bot commands are listed here

[civanch]

@bsunanda, FYI

[civanch]

type bugfix

[civanch]

@iarspider , @smuzaffar , this fix is independent on vecgeom problem.

[smuzaffar]

please test for CMSSW_12_4_GEANT4_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cb9ff/23683/summary.html COMMIT: 3d4dd18d7c5820c693e374fe988e83b287515418 CMSSW: CMSSW_12_4_GEANT4_X_2022-04-05-2300/slc7_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/geant4/58/23683/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 6935 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 68531 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 431373
• DQMHistoTests: Total nulls: 313
• DQMHistoTests: Total successes: 3161331
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 2.896 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.713 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): 2.606 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 136.874 ): -0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 138.4 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 138.5 ): -0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 25202.0 ): -0.598 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): 3.154 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 8.0 ): -1.537 KiB SiStrip/MechanicalView
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: found differences in 18 / 47 workflows

[civanch]

@smuzaffar , this PR fix incorrect physics, so regression is not expected. This PR can be merged to both GEANT4 and G4VECGEOM branches.

[smuzaffar]

+externals @aandvalenzuela can you please take care of it. Please merge this PR and note the latest commit hash of cms/v11.0.1 branch and then open PRs for

• GEANT4 IBs: cms-sw/cmsdist branch IB/CMSSW_12_4_X/geant4 branch
• G4VECGEOM IBs: cms-sw/cmsdist branch IB/CMSSW_12_4_X/geant4_vecgeom

all you need is to get the latest commits in the geant4.spec file for the above cmsdit branches. Thanks,

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next cms/v11.0.1 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

thanks @aandvalenzuela @civanch , cmsdist PRs are open now and once tests are done then we will include these for next G4* IBs