search

cms-externals / geant4

CMS mirror of Geant4 sources. Not endorsed by Geant4 organization itself under any circumstance.
Other
2 stars 6 forks source link

Fixed Geant4 compound materials construction #59

Closed civanch closed 2 years ago

civanch commented 2 years ago

This PR provide fix of construction of CMS compound materials from G4Elements and G4Materials, when Geant4 11.0.1 is used. It is essential for Run2 but also useful for Run3 and Phase-2 WFs. This fix has nothing to do with VecGeom.

cmsbuild commented 2 years ago

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for branch cms/v11.0.1.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. @perrotta, @dpiparo, @qliphy you are the release manager for this. cms-bot commands are listed here

smuzaffar commented 2 years ago

please test for CMSSW_12_4_GEANT4_X

cmsbuild commented 2 years ago

-1

Failed Tests: UnitTests Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a818cf/23931/summary.html COMMIT: 7a2b8268e533d5f7d5f31ce4be378d6fc4a95d8f CMSSW: CMSSW_12_4_GEANT4_X_2022-04-12-2300/slc7_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/geant4/59/23931/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a818cf/23931/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a818cf/23931/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testMakeTrackValidationPlots had ERRORS

Comparison Summary

Summary:

civanch commented 2 years ago

@smuzaffar , thanks for the merge, all tests in GEANT4 branch are fine, no warning anymore both in Run2 and Run3 WFs.