search

cms-externals / geant4

CMS mirror of Geant4 sources. Not endorsed by Geant4 organization itself under any circumstance.
Other
2 stars 6 forks source link

Collection of fixes for Geant4 11.1 #67

Closed civanch closed 1 year ago

civanch commented 1 year ago

Proposed number of fixes on top of the new Geant4 11.1 for early testing within CMSSW. Most of these fixes are technical. Essential for CMS simulation:

1) G4GammaGeneralProcess - avoid rare cases when concrete Geant4 process is not chosen due to inaccurate arithmetics. 2) G4NeutronGeneralProcess - removed unnecessary double computation of cross section. 3) Added to the list of processes forgotten new process of muon pair production by muons

In general, this patch may change simulation history but for some WF regression may be preserved due to limited statistics.

After merge of this PR new PRs to use updated Geant4 11.1 should be created for GEANT4 and G4VECGEOM branches of CMSSW.

cmsbuild commented 1 year ago

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for branch cms/v11.1.0.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. @perrotta, @dpiparo, @rappoccio you are the release manager for this. cms-bot commands are listed here

iarspider commented 1 year ago

please test

cmsbuild commented 1 year ago

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-347d37/29780/summary.html COMMIT: d2891d5b91e169a5b4fe2a8857ba5e3b88f38ca3 CMSSW: CMSSW_13_0_X_2023-01-01-2300/el8_amd64_gcc11 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/geant4/67/29780/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building: 

CMakeLists.txt:50 (include)


-- Configuring incomplete, errors occurred!
See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/geant4/10.7.2-1d5f307b025083ce25b5ec9c55048d4d/build/CMakeFiles/CMakeOutput.log".
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.5huRK6 (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+geant4+10.7.2-1d5f307b025083ce25b5ec9c55048d4d
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.5huRK6 (%build)
civanch commented 1 year ago

It seems that failed build can be ignored, because modifications in the cms/v11.1.0 branch are tested in the master.

smuzaffar commented 1 year ago

please test for CMSSW_13_0_GEANT4_X

civanch commented 1 year ago

@smuzaffar , there is inconsistency in clhep and geant4 versions:

The following configuration files were considered but not accepted:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/clhep/2.4.5.1-47a59842f4586f2cb0f8e5db68e38998/lib/CLHEP-2.4.5.1/CLHEPConfig.cmake, version: 2.4.5.1

smuzaffar commented 1 year ago

@civanch , https://github.com/cms-externals/geant4/pull/67#issuecomment-1368857274 is not a valid test result. As you have noted that tests were run against master cmssw branch (where we have old clhep and geant4 10.7.2) so please ignore that result. I have restarted the GEANT4_X tests and now externals are built successfully and now cmssw is in build process.

cmsbuild commented 1 year ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-347d37/29785/summary.html COMMIT: d2891d5b91e169a5b4fe2a8857ba5e3b88f38ca3 CMSSW: CMSSW_13_0_GEANT4_X_2023-01-01-2300/el8_amd64_gcc11 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/geant4/67/29785/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

civanch commented 1 year ago

@smuzaffar , can this PR be merged in this form?

smuzaffar commented 1 year ago

done @civanch , this should be part of net GEANT4/G4VECGEOM IBs