Cleanup - Githubissues

cms-gem-daq-project / ctp7_modules

0 stars 13 forks source link

Cleanup #105

Closed jsturdy closed 5 years ago

jsturdy commented 5 years ago

Description

Replace all localArgs initialization with GETLOCALARGS
Clean up some (not all) formatting mismatches
Close all RPC callbacks with rtxn.abort()

Types of changes

[x] Cosmetic/cleanup

Motivation and Context

Needed to happen, did it now to just be done with it

jsturdy commented 5 years ago

Fixed the error introduced, did not touch the persisting style errors. There are plenty of other style issues that need cleanup (inconsistent spacing, overabundance of comments for control flow, if/else block style consistency, etc.) that are not addressed here.

jsturdy commented 5 years ago

@lmoureaux started to put my comments into the cmsgemos CONTRIBUTING.md guidelines when he started work on the gemonlinedb package; and as mentioned in a few threads, my style choices are a semi-random mish-mash of various styles :-D We can try to standardize those more.