cms-gem-daq-project / ctp7_modules

0 stars 13 forks source link

[packaging] Implement correct packaging #114

Closed mexanick closed 5 years ago

mexanick commented 5 years ago

The PR is ready for review, but will require a config submodule bump after merge of https://github.com/cms-gem-daq-project/gembuild/pull/2

Description

Implements correct packaging, dependencies handling (almost! we may need to update dependencies list) and post-install linking scripts Fixes #78 and #28 Requires https://github.com/cms-gem-daq-project/gembuild/pull/2

Types of changes

Motivation and Context

Required for proper versioning and system setup

How Has This Been Tested?

Installed on eagle64

Screenshots (if appropriate):

Checklist:

bdorney commented 5 years ago

I don't think I'm knowledgable enough about gembuild and the make process in general to review this PR.

mexanick commented 5 years ago

I don't think I'm knowledgable enough about gembuild and the make process in general to review this PR.

I wanted to advertise your attention, that this long-requested functionality is now available

mexanick commented 5 years ago

@jsturdy your suggestions implemented

bdorney commented 5 years ago

What are the consequences of this being merged? e.g. do the build instructions reported:

Need to be updated?

What post build actions are now required? e.g. previously:

<make package>
cd ctp7_modules/lib
scp *.so <ctp7>
<restart rpcsvc>

Was all that was required, does this procedure change...?

bdorney commented 5 years ago

@jsturdy @mexanick

jsturdy commented 5 years ago

What are the consequences of this being merged? e.g. do the build instructions reported:

None, this only impacts the RPM