[Hotfix] release/v1.1.X: Change check on ohMask - Githubissues

cms-gem-daq-project / ctp7_modules

0 stars 13 forks source link

[Hotfix] release/v1.1.X: Change check on ohMask #121

Closed bdorney closed 5 years ago

bdorney commented 5 years ago

Description

ohMask was being called invalid if it was greater than 0x3ff (10 bits), while the message claimed it was supporting 12 OptoHybrids

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

See bug reported by @fsimone91 here

How Has This Been Tested?

QC8 team was again able to take data, see result.

Screenshots (if appropriate):

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

bdorney commented 5 years ago

superceded by https://github.com/cms-gem-daq-project/ctp7_modules/pull/123