GE2/1 compatilibility

[mexanick]

Addressing #131

Description

• Adding hw_constants for ge21
• Implementing constants usage
• Minor improvements w.r.t warnings and gbt logging

The changes should be transparent and does not require changes in the other software for the GE1/1 usage

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

The hardware constants has to be defined in one place and corresponding compile-time switch has to be used

How Has This Been Tested?

Tested with the GE2/1 integration stand setup

Screenshots (if appropriate):

Checklist:

• [x] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have added tests to cover my changes.
• [x] All new and existing tests passed.

[jsturdy]

Is this targeting "working now with setups that may be using legacy", if so, needs to target release/1.1.X, which is what I understand based on the dependent PRs

[bdorney]

It’s possible I missed other blocks in the code due to not appearing here. Especially in the calibration toolkit.

[mexanick]

@bdorney @lpetre-ulb your comments has been addressed except first one from @bdorney which I believe deserves a separate issue

[bdorney]

After another pass on this PR I think the struct ADCChannel also needs to be done for both ge11 and ge21 namespaces as there are probably a different number (and location) of temperature sensors between GE2/1 and GE1/1 optohybrids:

https://github.com/cms-gem-daq-project/ctp7_modules/blob/2c5d65f667e50ca95f733608e8768bf2086fd3f8/include/amc/sca_enums.h#L211-L267

Also I would suggest a look at all structs and enums declared here as they may also need namespace protection for things like different channels on the SCA ADC used to monitor different voltages, additional channels being used, additional monitoring, different pin out, etc...

I think we should address this given the board design has been completed in this PR. Apologies for having missed this earlier.

[mexanick]

I agree that SCA enums has to be changed, but I don't have any info on this w.r.t. GE2/1. Can anyone point me to where I can get it?

[lpetre-ulb]

@mexanick, you should be able to find all the information in the GE2/1 OH specification and/or on the GE2/1 OH schematic : http://padley.rice.edu/cms/OH_GE21/ohdesign.html

[mexanick]

Should these changes still go to develop or you prefer them to go under legacy/1.1.X branch?

[mexanick]

Changed the target and performed a rebase

[bdorney]

Approving these changes per discussion in meeting; but if @mexanick you could open a new issue on the repo to address the SCA enum issues we discussed for GE1/1 vs. GE2/1 issues.

[mexanick]

Merging as is, further refactoring foreseen