cms-gem-daq-project / ctp7_modules

0 stars 13 forks source link

Added remote callable function for confCalPulseLocal #135

Closed ram1123 closed 5 years ago

ram1123 commented 5 years ago

Added remote callable function for confCalPulseLocal as described in Issue #129.

Description

Added remote callable function for confCalPulseLocal. Along with it, I also updated the error message of in the local function confCalPulseLocal for the scenario having VFAT channel > 128.

Previous behaviour

https://github.com/cms-gem-daq-project/ctp7_modules/blob/ab4ddd0019976031c39251b719c698873b978c45/src/calibration_routines.cpp#L45-L48

Current behaviour

    else if (ch >= 128) { //Case: Bad Config, asked for OR of all channels
        la->response->set_string("error","confCalPulseLocal(): I was told to calpulse (on/off) channels > 128.");
        return false;
    } //End Case: Bad Config, asked for OR of all channels

https://github.com/ram1123/ctp7_modules/blob/ad9d0906773d139067c0b7dc05fbd918e2f17aca/src/calibration_routines.cpp#L56-L59

Types of changes

Motivation and Context

How Has This Been Tested?

This has been tested by running the script using its various combination of input parameter. Then read the same written register using gem_reg.py tool.

Screenshots (if appropriate):

Checklist: