Feature/read write export - Githubissues

cms-gem-daq-project / ctp7_modules

0 stars 13 forks source link

Feature/read write export #171

Closed mexanick closed 4 years ago

mexanick commented 4 years ago

Description

Refactor utils module to achieve better server/common separation
Add export operators for
- readRemoteReg
- readRemoteBlock
- writeRemoteReg
  Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

These methods are required for cmsgemos code in order to remove dependency from uHAL

How Has This Been Tested?

Compile-time checks passed, pending hardware access test

Screenshots (if appropriate):

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

lpetre-ulb commented 4 years ago

After review of https://github.com/cms-gem-daq-project/cmsgemos/pull/327, readRemoteBlock doesn't seem to be required. Could it be not exported at all?