Current setChannelRegistersVFAT3Local() method performs 6 write transactions per channel (calenable, maks, trimARM, trimARM polarity, trimZCC, trimZCC polarity). This is excessive and unnecessary. I have updated the module to build the overall channel register in the appropriate bits and then perform a single write transaction for the channel.
Additionally this provides a function for reading back the channel registers getChannelRegistersVFAT3Local() and it's "remote" equivalent.
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Motivation and Context
The setChannelRegistersVFAT3Local() runs slow and there was no RPC method for reading back the vfat3 settings.
How Has This Been Tested?
(py2.7) [dorney@gem904qc8daq]~/scratch0/CMS_GEM/CMS_GEM_DAQ% date
Fri Jul 13 15:10:13 CEST 2018
(py2.7) [dorney@gem904qc8daq]~/scratch0/CMS_GEM/CMS_GEM_DAQ% confChamber.py -c eagle60 -g1 --vfatmask=0xf9f0f --zero
2018.07.13.15.10
Open pickled address table if available /opt/cmsgemos/etc/maps/amc_address_table_top.pickle...
Initializing AMC eagle60
My FW release major = 3
opened connection
biased VFATs
Set CFG_THR_ARM_DAC to 100
zero'ing all channel registers
Chamber Configured
(py2.7) [dorney@gem904qc8daq]~/scratch0/CMS_GEM/CMS_GEM_DAQ% date
Fri Jul 13 15:10:20 CEST 2018
Description
Current
setChannelRegistersVFAT3Local()
method performs 6 write transactions per channel (calenable, maks, trimARM, trimARM polarity, trimZCC, trimZCC polarity). This is excessive and unnecessary. I have updated the module to build the overall channel register in the appropriate bits and then perform a single write transaction for the channel.Additionally this provides a function for reading back the channel registers
getChannelRegistersVFAT3Local()
and it's "remote" equivalent.Types of changes
Motivation and Context
The
setChannelRegistersVFAT3Local()
runs slow and there was no RPC method for reading back the vfat3 settings.How Has This Been Tested?
The log on the card is:
Working as expected.
Checklist: