remove all requests for the 'ohVfatMaskArray' key

AndrewLevin commented 5 years ago

As requested in https://github.com/cms-gem-daq-project/ctp7_modules/issues/48, I have removed all instances in this repository where a "ohVfatMaskArray" key is requested in an rpc call.

Description

Instead of getting the mask array from the rpc call, I get it from the getOHVFATMaskLocal whenever it is needed. There were two functions where this occurred and was changed:

1) readVFAT3ADCMultiLink in vfat3.cc 2) configureVFAT3DacMonitorMultiLink in vfat3.cc

Note: https://github.com/cms-gem-daq-project/ctp7_modules/pull/47 which was recently merged already implemented this change in the function dacScanMultiLink in calibration_routines.cpp

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

This pull request is intended to add the feature requested in https://github.com/cms-gem-daq-project/ctp7_modules/issues/48.

How Has This Been Tested?

I have compiled the changes and tested them on eagle64 as described in http://cmsonline.cern.ch/cms-elog/1066648

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

bdorney commented 5 years ago

I have checked that the changes compile.

In the future this should not be viewed as a completed test. At bare minimum things should compile...but you need to test on the card itself. You can submit PR's before testing is completed, and then add to them as things go; but please place WIP on the PR and this will automatically be tagged by our git status checks.

AndrewLevin commented 5 years ago

@bdorney, @sturdy, @mexanick, all tests were successful, so the pull request is ready for your review

bdorney commented 5 years ago

One aesthetic change needed; otherwise looks good.

AndrewLevin commented 5 years ago

@bdorney, the whitespace you mentioned is removed now

cms-gem-daq-project / ctp7_modules