Hot Fix: Resolved std::string vs const char * issue - Githubissues

cms-gem-daq-project / gem-light-dqm

GEM light DQM code

0 stars 17 forks source link

Hot Fix: Resolved std::string vs const char * issue #31

Closed bdorney closed 5 years ago

bdorney commented 5 years ago

Description

Not sure why this wasn't caught at compile time, it only shows up at runtime...but fixed a type mismatch.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

Didn't work.

How Has This Been Tested?

Okay now I actually tested it by re-analyzing old data.

Screenshots (if appropriate):

Screen Shot 2019-03-11 at 12 10 36 PM

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

bdorney commented 5 years ago

I believe it wasn't caught at compile time because this file is actually not compiled at the compile time, but only compiled at the worker, i.e. during the runtime.

I get it; makes perfect sense.