search

cms-gem-daq-project / gem-light-dqm

GEM light DQM code
0 stars 17 forks source link

Added histgrams BX and EC mismatch: #35

Closed giovanni-mocellin closed 5 years ago

giovanni-mocellin commented 5 years ago
mexanick commented 5 years ago

Before I go into detailed code review, why it is here at all? This functionality should go to Online DQM, if required, not in the temporary version of the expert tool.

giovanni-mocellin commented 5 years ago

This is what we have used to identify which issues we had on the passed data takings. Probably to monitor what is happening in the future ones, if the system stays stable or not, it has been asked by Brian to have it pull requested in this repo.

bdorney commented 5 years ago

Before I go into detailed code review, why it is here at all? This functionality should go to Online DQM, if required, not in the temporary version of the expert tool.

Hey @mexanick I agree 100% with your assessment; and with @jsturdy have discussed that the trick is that the status bits in the event format just need to be changed from always being set to zero to being meaningful. Specifically for VFAT-AMC BX Mismatch this should be changed. And then I would propose both in the FW and the event format to have VFAT-OH BX Mismatch changed to VFATX-VFATY BX Mismatch (this was the actual problem).

However @evka85 is on holiday for the next two weeks and we need a tool to be able to investigate this in the interim so I asked for a SW hack by @giovanni-mocellin and this was the fastest/simplest solution.

giovanni-mocellin commented 5 years ago

Just pushed a commit to conform the code to the indentation style