The vfat3 team has decided to change the convention for the calibration coefficients calDAC2Q_m and calDAC2Q_b. Previously in voltage step mode the "inverted" CFG_CAL_DAC register value was used, i.e.:
Q = calDAC2Q_m * (256 - CFG_CAL_DAC) + calDAC2Q_b
Now the raw register value will be used, e.g.:
Q = calDAC2Q_m * (CFG_CAL_DAC) + calDAC2Q_b
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X] Maintenance (updates to the software that are transparent to the user)
Motivation and Context
This was reported by Henri who is developing the vfat3 production testing:
My idea was to make the fit on the raw register value so the charge equation for the voltage mode would become:
Q=m*CAL_DAC+b
which in my mind would be more straight forward and avoid confusion about when the inversion is used and when not.
How Has This Been Tested?
Took a new scurve and analyzed the data.
Screenshots (if appropriate):
Note VFAT5 & 12 were masked in this test.
Checklist:
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
Description
The
vfat3team has decided to change the convention for the calibration coefficientscalDAC2Q_mandcalDAC2Q_b. Previously in voltage step mode the "inverted"CFG_CAL_DACregister value was used, i.e.:Now the raw register value will be used, e.g.:
Types of changes
Motivation and Context
This was reported by Henri who is developing the
vfat3production testing:How Has This Been Tested?
Took a new scurve and analyzed the data.
Screenshots (if appropriate):
Note VFAT5 & 12 were masked in this test.
Checklist: