cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools
GNU General Public License v3.0
1 stars 26 forks source link

Bug Fix: Bad histo range and superfluous warning message printing in anaUltraScurve.py #119

Closed bdorney closed 6 years ago

bdorney commented 6 years ago

Description

When not supplying the --isVFAT3 option (e.g. for v2b electronics) the y-axis range of histograms made by anaUltraScurve.py was incorrect (e.g. min = max and max = min). Additionally superfluous message printing during fitting due to poor choice of parameter limits is addressed.

Types of changes

Motivation and Context

Couldn't analyze v2b electronics. Annoyed by meaningless message spam.

How Has This Been Tested?

Re-analyzed old data.

Screenshots (if appropriate):

scurve_burned_vfat2_by_vfatchannels

Checklist:

bdorney commented 6 years ago

ah, it's because you're using an integer string format for a boolean type (works for True/False but not, by design, None), formatting it as a boolean (%r) or casting the value to a bool in your current implementation would work in all cases

I'll resolve this in a later PR. Thanks for the feedback.