cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools
GNU General Public License v3.0
1 stars 26 forks source link

Feature box plot #152

Closed caruta closed 6 years ago

caruta commented 6 years ago

Description

A new 2D histogram containing the values of noise for each VFATs has been added. It is drawn as a box plot in order to facilitate the visualization of the main characteristics of the noise distributions.

Types of changes

Motivation and Context

It helps the visualization of the main characteristics of the noise distribution for each VFAT.

How Has This Been Tested?

It has been tested comparing the results of two scurves taken in different conditions: HV ON & HV OFF.

Screenshots (if appropriate):

canvscurvesigma_boxplot

Checklist:

bdorney commented 6 years ago

Also it seems your branch caruta:feature_BoxPlot is out of date with the central repository.

To resolve this, after having committed all changes to feature_BoxPlot, execute:

git checkout develop
git pull <name of gemdaq repo> develop
git checkout feature_BoxPlot
git rebase develop

This will apply your changes, one at a time, onto develop automatically. If a conflict occurs you'll need to resolve it manually. You can ask me on Mattermost for how to do this if it occurs.

bdorney commented 6 years ago

Student leaves tomorrow @jsturdy @mexanick @BenjaminRS. If you could review PR today would be appreciated. Otherwise I will force merge tomorrow and resolve any discrepancies myself.