WIP: Fixed issue w/vfatID only storing 16 bit numbers

bdorney commented 6 years ago

Description

Fixed issue w/vfatID only storing 16 bit numbers. Due to the vfat bit slip problem you can get a chip ID that has a number that is larger than 16 bits.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

Allow VFAT ID to take up to 32 bit numbers

How Has This Been Tested?

Change was trivial.

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

bdorney commented 6 years ago

The issue is due to the bit slip problem on the chop ID. And why an additional two bits help I would guess is due to the chance to have it in the first set is more likely.

In any case, I’ll change it to a 32 bit container integer, and then have ROOT write it as a 32 bit integer. Really was just expecting a number between 0 and 5000.

bdorney commented 6 years ago

superseded by https://github.com/cms-gem-daq-project/gem-plotting-tools/pull/160

cms-gem-daq-project / gem-plotting-tools