These are two unrelated but simple improvements to the anaDACScan.py script.
Description
Currently, anaDACScan.py will just warn the user when the fitted nominal DAC values are below 0 or above the maximum range of the register. This PR replaces the out-of-range nominal DAC values with 0 or the maximum value, in addition to printing a warning.
Currently, the handling of the calibration file would fail if a tab or multiple spaces separated the columns. This can be fixed very easily.
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
AndrewLevin
commented
5 years ago
These are two unrelated but simple improvements to the anaDACScan.py script.
Description
Currently, anaDACScan.py will just warn the user when the fitted nominal DAC values are below 0 or above the maximum range of the register. This PR replaces the out-of-range nominal DAC values with 0 or the maximum value, in addition to printing a warning.
Currently, the handling of the calibration file would fail if a tab or multiple spaces separated the columns. This can be fixed very easily.
Types of changes
Motivation and Context
The replacement of out-of-range nominal DAC values was requested by @bdorney in a gemctp7user PR https://github.com/cms-gem-daq-project/gemctp7user/pull/37#pullrequestreview-168729078.
The issue with the calibration file handling was obvious.
How Has This Been Tested?
I have run the updated script successfully on DAC scan data on gem904daq01.
Screenshots (if appropriate):
Checklist: