Resolving issue #16, wrong VFAT DAC issues assigned by default

bdorney commented 7 years ago

Description

Addressing: https://github.com/cms-gem-daq-project/gem-plotting-tools/issues/16

VFAT DAC registers will no longer be written with outdated values.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

Previously the wrong VFAT DAC values (old and outdated) were being written when configuring the chamber as described in https://github.com/cms-gem-daq-project/gem-plotting-tools/issues/16

How Has This Been Tested?

Tested here: http://cmsonline.cern.ch/cms-elog/1004364

Screenshots (if appropriate):

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

bdorney commented 7 years ago

By default whenever a call of vfatqc-python-scripts/confChamber.py occurs, either via vfatqc-python-scripts/confAllChambers.py or directly from command line, all values will be set from cmsgemos/gempython/tools/vfat_user_functions.py

Then as a last step of the configuration vfatqc-python-scripts/confChamber.py will check if the link supplied as an argument is present in chamber_vfatDACSettings. If so vfatqc-python-scripts/confChamber.py will re-write the DAC settings with those given in the chamber_vfatDACSettings dictionary as shown in Lines 91-102 of vfatqc-python-scripts/confChamber.py:

if options.gtx in chamber_vfatDACSettings.keys():
    try:
        print "Configuring VFATs with chamber_vfatDACSettings dictionary values"
        writeAllVFATs(ohboard, options.gtx, "IPreampIn", chamber_vfatDACSettings[options.gtx]["IPreampIn"], 0)
        writeAllVFATs(ohboard, options.gtx, "IPreampFeed", chamber_vfatDACSettings[options.gtx]["IPreampFeed"], 0)
        writeAllVFATs(ohboard, options.gtx, "IPreampOut", chamber_vfatDACSettings[options.gtx]["IPreampOut"], 0)
        writeAllVFATs(ohboard, options.gtx, "IShaper", chamber_vfatDACSettings[options.gtx]["IShaper"], 0)
        writeAllVFATs(ohboard, options.gtx, "IShaperFeed", chamber_vfatDACSettings[options.gtx]["IShaperFeed"], 0)
        writeAllVFATs(ohboard, options.gtx, "IComp", chamber_vfatDACSettings[options.gtx]["IComp"], 0)
    except Exception as e:
        print 'Error configuring the VFATs with chamber_vfatDACSettings dictionary values'
        print e

jsturdy commented 7 years ago

OK, I see

cms-gem-daq-project / gem-plotting-tools