cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools
GNU General Public License v3.0
1 stars 26 forks source link

Bug Fix: Resolved a type mismatch error #178

Closed bdorney closed 5 years ago

bdorney commented 5 years ago

Description

Changed mapVFATPos2VFATSN from int32 to uint32 data type. This resolves a type mismatch in older versions of numpy and is also more correct. The vfatID is treated as an unsigned 32 bit integer due to the possibility of bit flips in the chipID register.

Types of changes

Motivation and Context

Resolves type issue shown here.

How Has This Been Tested?

Ran analysis without having the problem in older version of numpy.

Screenshots (if appropriate):

Checklist:

bdorney commented 5 years ago

I think I'm just gonna make VFAT serial number a float until reed muller comes along.